Fix for device display issues #2403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Apr 2, 2023
thebentern
approved these changes
Apr 3, 2023
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Apr 3, 2023
|
Hold on... I need to (re-)test the router mode... done! |
marked as draft, give us a ring when it's ready ... |
caveman99
requested changes
Apr 3, 2023
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Apr 3, 2023
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Apr 3, 2023
caveman99
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #2402 Screen issues on device display.
Regarding the issues mentioned in #2402 :-
1- the missing screen blanking is fixed by adding a new state transition from POWER -> DARK
2- the missing screen blanking while in DARK (when displaying a message) is fixed by adding a new state transition DARK -> DARK
3- to show all nodes right from the beginning the node number is taken from nodeDB
4- a couple of state checks fix the unwanted display of "powered... ", "unpowered...". Tested well on Tbeam with insertion/removal of USB cable.
5+6- the button GPIO sleep issue and crash is fixed
7- FREE GIFT: Router IRQ wakeup for SX126x/SX128x is fixed!!! Saw this when I corrected the button GPIO sleep issue.