use BSEC lib for BME680 #2426
Merged
use BSEC lib for BME680 #2426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Apr 12, 2023
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Apr 12, 2023
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Apr 13, 2023
caveman99
commented
Apr 14, 2023
| if (!hasSensor()) { | ||
| return DEFAULT_SENSOR_MINIMUM_WAIT_TIME_BETWEEN_READS; | ||
| } | ||
| status = bme680.begin(nodeTelemetrySensorsMap[sensorType]); | ||
| bme680.begin(nodeTelemetrySensorsMap[sensorType], Wire); |
There was a problem hiding this comment.
How does the new I2C scan work if this is detected on the secondary bus? Right now all sensors assume 'Wire'
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Apr 14, 2023
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Apr 14, 2023
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Apr 15, 2023
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.