UI/UX: Display delivered message on incoming ACK. #2739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caveman99
commented
Aug 22, 2023
🤖 Pull request artifacts
|
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Aug 22, 2023
caveman99
force-pushed
the
delivery-report
branch
from
07a57da to
a06e50a
Compare
caveman99
force-pushed
the
delivery-report
branch
from
435ac8f to
5b54b4d
Compare
caveman99
force-pushed
the
delivery-report
branch
from
5b54b4d to
996c168
Compare
caveman99
force-pushed
the
delivery-report
branch
from
996c168 to
6352119
Compare
caveman99
force-pushed
the
delivery-report
branch
2 times, most recently
from
5e70fb9 to
b181ec0
Compare
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Dec 3, 2023
jp-bennett
pushed a commit
to meshtastic/artifacts
that referenced
this pull request
Dec 11, 2023
caveman99
force-pushed
the
delivery-report
branch
from
b181ec0 to
5d94bb6
Compare
- only works if we don't have a phone connected, but that is probably dsired - this will send a copy of device-originating text messgaes to a connected phone. Breaking change. - this will iterate the tophone queue by deconstructing and reconstructing it every time we look for an ID. Probably also mangles the queue oder since it aborts when a ID is found. - Can we navigate the packet pool instead? If so, how? - Let's keep this in draft state for now
the memory pool can NOT be iterated easily, since it's not a linear object.
jp-bennett
reviewed
Dec 11, 2023
thebentern
approved these changes
Dec 11, 2023
GUVWAF
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Looks good to me.
I think we can eventually get rid of this special FreeRTOS queue for the ToPhoneQueue (seems this was actually the plan) to handle persistent storage for message history on standalone devices. If we can replace it by a MeshPacketQueue, which is actually a std::vector, we can more easily cycle through it and reorder packets.
|
@GUVWAF at least it would be easier to interate over something that is not handled by freeRTOS. Question is if the ISR variety of these commands are used at all. We need to handle blocking carefully if the are. |
|
i pushed the current state to master, let's keep this branch open to refine this further. I'll push canned messaging to secondary channels next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs more work, see comments.