Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible memory leak in NeighborInfo Module #2765

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Fix possible memory leak in NeighborInfo Module #2765

merged 2 commits into from
Sep 4, 2023

Conversation

GUVWAF
Copy link
Member

@GUVWAF GUVWAF commented Sep 4, 2023

Looks like this neighborInfo packet was never freed. This should actually not be dynamically allocated, it will be copied in the MeshPacket which is dynamically allocated with allocDataProtobuf().

jp-bennett
jp-bennett approved these changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@jp-bennett jp-bennett left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to fix the crash on my T-beam.
Spoke too soon. After an hour and 10 minutes, crashed again. It might be less often, or might be a coincidence.

@thebentern thebentern merged commit 17617ce into meshtastic:master Sep 4, 2023
@GUVWAF GUVWAF deleted the neighborMemLeak branch February 18, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebentern thebentern thebentern approved these changes

@jp-bennett jp-bennett jp-bennett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GUVWAF @jp-bennett @thebentern