Only update neighbors when module is enabled #2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can remove line 102, as it's no longer necessary with this change. |
|
That's right, done. |
code8buster
approved these changes
Sep 5, 2023
jp-bennett
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the NeighborInfoModule is not enabled, we shouldn't do any bookkeeping upon receiving a packet as we don't do anything with it and we also don't clean-up any neighbors, thus only consuming processing power/writes to flash (and it even caused a bug before #2767). It will still update the
last_sent_by_idwhen passing through it in the FloodingRouter.