New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gps cleanup and powersave #2807

Merged

jp-bennett merged 41 commits into master from gps-work

Sep 24, 2023

Collaborator

jp-bennett commented Sep 18, 2023

No description provided.

jp-bennett and others added 16 commits

September 12, 2023 18:35


          Use UINT32_MAX to indicate no configured GPS

cd6a151


          Refactor GPS to not probe if pins not defined

0445a39


          Minor cleanups related to rework

bec1a5f


          Use Named Constructor to clean up code

9f56825


          Actually disable the GPS thread

49bc19b


          Don't actually disable the GPS thread

d855621


          Move doGPSPowerSave to GPS class

79b6fdb


          Make sure to set GPS awake on triple-click

0f6a721


          Merge branch 'master' into gps-work

e4ca0f2


          Cleanup and remove dead code


          Rename GPS_PIN_WAKE to GPS_PIN_STANDBY

a19112f


          Actually put GPS to sleep between fixes

2df95e8


          Limit GPS powerdown to 1 minute or more sleep times

f85569d


          Merge branch 'master' into gps-work

619f21a


          Trunk check

34eb6fb


          More dead code removal

b1b1568

mverch67 reviewed

View reviewed changes

src/gps/GPS.h Outdated Show resolved Hide resolved

Collaborator

mverch67 commented Sep 18, 2023 •

edited

Loading

GPS.h line 185: void setNumSatellites(uint8_t n);

This method is never used (dead code?).

mverch67 reviewed

View reviewed changes

src/gps/GPS.cpp Outdated Show resolved Hide resolved

mverch67 reviewed

View reviewed changes

src/gps/GPS.cpp Show resolved Hide resolved

Contributor

code8buster commented Sep 18, 2023 •

edited

Loading

Is there any way you can break out into a couple smaller sets of changes?
edit: On second thought it might be alright.

mverch67 reviewed

View reviewed changes

src/gps/GPS.cpp Outdated Show resolved Hide resolved

mverch67 reviewed

View reviewed changes

src/gps/GPS.cpp Show resolved Hide resolved


          add GPS_POWER_TOGGLE for heltec-tracker and t-deck

2f25298

Contributor

github-actions bot commented Sep 18, 2023 •

edited

Loading

🤖 Pull request artifacts

file	commit
`pr2807-firmware-2.2.8.4ac00b1.zip`	`4ac00b1`

thebentern added a commit to meshtastic/artifacts that referenced this pull request


          Upload pr2807-firmware-2.2.7.2f25298.zip (2f252)

797eb33

Pull request: meshtastic/firmware#2807
Commit: meshtastic/firmware@2f25298


          Merge branch 'master' into gps-work

c69632a

Collaborator Author

jp-bennett commented Sep 18, 2023

Is there any way you can break out into a couple smaller sets of changes?
I'm leery of how many things are being packed into this; it can easily exceed my capacity in both time and hardware to test the corner cases of everything it touches.

That's fair. I'll see what I can do.

jp-bennett added 2 commits

September 18, 2023 11:10


          Change GPS_THREAD_INTERVAL to 200 ms

1ca6a15


          More dead code, compiler warnings, and add returns

b5c5070


          Track average GPS fix time to judge low-power time

a2df196

thebentern added a commit to meshtastic/artifacts that referenced this pull request


          Upload pr2807-firmware-2.2.8.a2df196.zip (a2df1)

88f2001

Pull request: meshtastic/firmware#2807
Commit: meshtastic/firmware@a2df196

jp-bennett added 3 commits

September 20, 2023 00:13


          Feed PositionModule on GPS fix

2baf3c9


          Don't turn off the 3v3_s line on RAK4631

5df2583

when the rotary is present.


          Make Trunk Happy

0a430b2

thebentern added a commit to meshtastic/artifacts that referenced this pull request


          Upload pr2807-firmware-2.2.8.0a430b2.zip (0a430)

50c6775

Pull request: meshtastic/firmware#2807
Commit: meshtastic/firmware@0a430b2


          Merge branch 'master' into gps-work

e306a89

jp-bennett marked this pull request as ready for review

September 22, 2023 01:45


          Add GPS power standbyOnly option

398dd9d

jp-bennett force-pushed the gps-work branch from 19ceeca to 398dd9d Compare

September 22, 2023 01:50

Collaborator Author

jp-bennett commented Sep 22, 2023

20 minutes with a GPS set to 120 second update times on a T-beam:
2.2.0: 187 mWh
This patch: 81 mWh

jp-bennett requested review from mverch67, caveman99, geeksville and thebentern

September 22, 2023 17:54


          Check for rotary encoder enabled on RAK4631

284e1d9

thebentern added a commit to meshtastic/artifacts that referenced this pull request


          Upload pr2807-firmware-2.2.8.284e1d9.zip (284e1)

a9ca580

Pull request: meshtastic/firmware#2807
Commit: meshtastic/firmware@284e1d9


          Delay setting time currentQuality

57dd5e8

to avoid strange log message.

mverch67 reviewed

View reviewed changes

src/gps/GPS.cpp Outdated Show resolved Hide resolved

mverch67 reviewed

View reviewed changes

src/modules/PositionModule.cpp Outdated Show resolved Hide resolved

jp-bennett and others added 6 commits

September 23, 2023 11:28


          Typos, comments, and remove unused variable

3ee1fa5


          Short-circuit the setAwake logic on GPS disable

350d8aa


          heltec-tracker 0.3 GPS power saving

40d9444


          set en_gpio to defined state

2ffa0d2


          Fix fixed_position logic with GPS disabled

f55edcc


          Don't process GPS serial when not isAwake

4ac00b1

thebentern added a commit to meshtastic/artifacts that referenced this pull request


          Upload pr2807-firmware-2.2.8.4ac00b1.zip (4ac00)

8e93f57

Pull request: meshtastic/firmware#2807
Commit: meshtastic/firmware@4ac00b1


          Add quirk for Heltec Tracker GPS powersave

d97999d

jp-bennett merged commit 1a2c7f0 into master

jp-bennett deleted the gps-work branch

September 24, 2023 04:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet