-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Pi Pico hang #2817
Fix for Pi Pico hang #2817
Conversation
Still hangs
|
Half a fix. Hang on. |
🤖 Pull request artifacts
|
Success! 🥳 At least on the Pico. Let me check the RAK11300 now. |
Success x2! RAK11310 is booting also. 🥳 Great work @jp-bennett |
2.2.8 does not work on the rp2040 pico |
The first generated .zip does not have the second half of the fix in it. |
@NickDolfin Can you try with the image generated here: https://github.com/meshtastic/firmware/actions/runs/6255294648#artifacts |
@jp-bennett Yes, you are right. I was to fast and downloaded the wrong one. Now 2.2.8 is working. Many thanks for the fast fix. |
The pico startup code was leaving _serial_gps set to null, but then failing to properly catch that state and short-circuit GPS probing. Fix by disabling the GPS thread when null.