Remove redundant checks for power of 0 #2934
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The power cannot be 0 once the execution results in whichever radio module interface initialised RadioInterface through RadioLibInterface, as the code below is executed (comment clarified)
Therefore, it is unecessary to then check again if power is 0 in each radio module's interface. This behaviour was found as the changes in #2813 which removed this check had no effect (the intention was to avoid accidentally setting 0 dBm to max power, but this should have not been done as this was intended behaviour as the default value sent in protobufs is empty (0) to reduce the message size, as in most cases you will be transmitting at the maximum allowed power), it didn't cause SX126x devices to transmit at 0 dBm, but continues behaving as before.