Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Remove node by nodenum admin message #2941

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Added Remove node by nodenum admin message #2941

merged 3 commits into from
Nov 16, 2023

Conversation

thebentern
Copy link
Contributor

@thebentern thebentern commented Nov 15, 2023 •
edited
Loading

Closes #1761

@thebentern thebentern requested a review from caveman99 November 15, 2023 15:45
@caveman99
Copy link
Member

There's similar code here... https://github.com/meshtastic/firmware/blob/6f09cead4c57a628c7be733f9dd88d83dd47d4e2/src/mesh/NodeDB.cpp#L847C1-L872C6 - bonus points for folding this into the change :-)

@thebentern thebentern merged commit 5d91788 into master Nov 16, 2023
57 checks passed
@tropho23 tropho23 mentioned this pull request Nov 16, 2023
Closed
@caveman99 caveman99 deleted the remove-node-by-nodenum branch November 16, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caveman99 caveman99 caveman99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request] Add ability to delete/remove individual nodes from nodedb
2 participants
@thebentern @caveman99