Add USB detection to RAK4631 based boards. #2956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caveman99
approved these changes
Nov 22, 2023
thebentern
approved these changes
Nov 22, 2023
|
Just tried on my nRF52 with integrated SX1262 no battery connected `DEBUG | ??:??:?? 61 [Power] Battery: usbPower=0, isCharging=0, batMv=0, batPct=0 // Testing USB detection DEBUG | ??:??:?? 65 [Power] Battery: usbPower=1, isCharging=1, batMv=0, batPct=0` |
|
Seems functional. Some systems will report a batterymv even when there is none - thats the charge current sharing a line with the batterymv detect line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add support for detecting if the USB cable is plugged in on the RAK4631-derived boards. It may also work for other NRF52 systems, but I don't have any I can test.
If you wish to test on an NRF board, simply add the define of NRF_APM to your variant.h and let me know how it works out.
The check runs on the power status update thread, so it can take 20 seconds to detect USB or no USB.
We assume the system is charging if there is a battery and USB is plugged in.