Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swapped out crypto engine for one that also works with AES-256 #2959

Merged
merged 4 commits into from
Nov 26, 2023

Conversation

caveman99
Copy link
Member

PLEASE TEST

Copy link
Contributor

🤖 Pull request artifacts

file commit
pr2959-firmware-2.2.14.8fc7f7a.zip 8fc7f7a

thebentern added a commit to meshtastic/artifacts that referenced this pull request Nov 23, 2023
Copy link
Member

@GUVWAF GUVWAF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, tested to be working for both AES128 and AES256 on a Pico:

DEBUG | ??:??:?? 21 [Router] Using AES256 key!
DEBUG | ??:??:?? 21 [Router] Installing AES256 key!
DEBUG | ??:??:?? 21 [Router] decoded message (id=0x60e47ad8 fr=0xe4 to=0xff, WantAck=0, HopLim=3 Ch=0x3 Portnum=1 rxSNR=6 rxRSSI=-12)
DEBUG | ??:??:?? 21 [Router] handleReceived(REMOTE) (id=0x60e47ad8 fr=0xe4 to=0xff, WantAck=0, HopLim=3 Ch=0x3 Portnum=1 rxSNR=6 rxRSSI=-12)
DEBUG | ??:??:?? 40 [Router] Expanding short PSK #1
DEBUG | ??:??:?? 40 [Router] Using AES128 key!
DEBUG | ??:??:?? 40 [Router] Installing AES128 key!
DEBUG | ??:??:?? 40 [Router] decoded message (id=0x497251e5 fr=0xe4 to=0x39, WantAck=0, HopLim=3 Ch=0x0 Portnum=4 requestId=54a468b1 rxSNR=6.25 rxRSSI=-11)
DEBUG | ??:??:?? 40 [Router] handleReceived(REMOTE) (id=0x497251e5 fr=0xe4 to=0x39, WantAck=0, HopLim=3 Ch=0x0 Portnum=4 requestId=54a468b1 rxSNR=6.25 rxRSSI=-11)

@caveman99 caveman99 merged commit c7e3485 into master Nov 26, 2023
60 checks passed
@caveman99 caveman99 deleted the rp2040-aes branch November 26, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants