Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old SX126x and SX128x boosted gain commented-out code #2976

Merged
merged 4 commits into from
Dec 27, 2023
Merged

Remove old SX126x and SX128x boosted gain commented-out code #2976

merged 4 commits into from
Dec 27, 2023

Conversation

S5NC
Copy link
Contributor

@S5NC S5NC commented Dec 1, 2023

Old, now another method is used. Old usage. Perhaps the boosted gain mode should be set again during reconfigure, or is this done elsewhere?

caveman99
caveman99 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@caveman99 caveman99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably good to add it to the re-init too...

@S5NC
Copy link
Contributor Author

S5NC commented Dec 2, 2023

probably good to add it to the re-init too...

Which settings are reapplied because of the applyModemConfig() call, and which need to be done separately? I might be simpler to delete and recreate the lora.

@thebentern thebentern marked this pull request as ready for review December 27, 2023 14:18
@thebentern thebentern merged commit d401040 into meshtastic:master Dec 27, 2023
31 of 32 checks passed
@S5NC S5NC deleted the removeOldBoostedGain branch December 28, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caveman99 caveman99 caveman99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@S5NC @caveman99 @thebentern