Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set NRF cpu brownout at 2.4V instead of running down to the limit #3016

Merged
merged 4 commits into from
Dec 16, 2023

Conversation

thebentern
Copy link
Contributor

Closes #2936 hopefully.
@pdxlocations can you try to repro with the build assets from this change on a RAK?

@pdxlocations
Copy link
Member

Closes #2936 hopefully. @pdxlocations can you try to repro with the build assets from this change on a RAK?

Sure thing, um where can I find the assets again?

@garthvh
Copy link
Member

garthvh commented Dec 15, 2023

Closes #2936 hopefully. @pdxlocations can you try to repro with the build assets from this change on a RAK?

Sure thing, um where can I find the assets again?

https://github.com/meshtastic/firmware/actions/runs/7215104198

@thebentern
Copy link
Contributor Author

Going to go ahead and integrate this since it's a safer voltage threshold to brownout on.

@thebentern thebentern merged commit 1c6acfd into master Dec 16, 2023
56 of 58 checks passed
@thebentern thebentern deleted the brownout-earlier branch December 16, 2023 12:57
@pdxlocations
Copy link
Member

Going to go ahead and integrate this since it's a safer voltage threshold to brownout on.

Makes sense.

I was able to start testing last night. I started with a factory reset and installed the 2.2.14 release to make sure I could re-create the issue. Funny thing is, I let the battery drain about 15 times and the board never reset to defaults. This was using the same board and battery that I had experienced the issue on at least once before. I never got to installing your build asset.

I'll try to recreate on the another board/batt I had originally experienced this with.

@ulrichard
Copy link

Is there a chance this will help with https://meshtastic.discourse.group/t/rak-4631-solar-repeater/7694/4 or is it completely unrelated?

@garthvh
Copy link
Member

garthvh commented Dec 18, 2023

Is there a chance this will help with https://meshtastic.discourse.group/t/rak-4631-solar-repeater/7694/4 or is it completely unrelated?

completely unrelated, that discord post is not real accurate either.

@CyberRatingsTim
Copy link

testing on current 2.4 both at low battery (around 2.49v) go into a boot loop and lose settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Reset to Defaults when Battery Dies
5 participants