Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicit ACKs when sending a message to a channel didn’t work when using purely MQTT, because we were filtering out messages we originally sent.
I think it’s safe to remove this, because we do check for the
gateway_id
already in order to avoid loops with MQTT:firmware/src/mqtt/MQTT.cpp
Lines 133 to 134 in 16a3a32
Just checked with two devices connected to MQTT with LoRa Tx disabled and I do get ACKs now on the primary channel. The device will create an ACK when receiving the rebroadcast, so it also avoids unnecessary retransmissions.
ACKs for DMs work already.