Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make implicit ACKs work on MQTT #3028

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

GUVWAF
Copy link
Member

@GUVWAF GUVWAF commented Dec 20, 2023

Implicit ACKs when sending a message to a channel didn’t work when using purely MQTT, because we were filtering out messages we originally sent.

I think it’s safe to remove this, because we do check for the gateway_id already in order to avoid loops with MQTT:

firmware/src/mqtt/MQTT.cpp

Lines 133 to 134 in 16a3a32

if (strcmp(e.gateway_id, owner.id) == 0)
LOG_INFO("Ignoring downlink message we originally sent.\n");

Just checked with two devices connected to MQTT with LoRa Tx disabled and I do get ACKs now on the primary channel. The device will create an ACK when receiving the rebroadcast, so it also avoids unnecessary retransmissions.

ACKs for DMs work already.

Don't filter out messages we originally sent via LoRa
@thebentern thebentern merged commit d88baea into meshtastic:master Dec 21, 2023
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants