Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow override of HWID using environment variable #3036

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Allow override of HWID using environment variable #3036

merged 3 commits into from
Dec 27, 2023

Conversation

wnagele
Copy link
Contributor

@wnagele wnagele commented Dec 24, 2023

When testing sometimes it is useful to be able to set this explicitly.

@wnagele
Copy link
Contributor Author

wnagele commented Dec 24, 2023

The check failures are from pre-existing Dockerfile issues. I'd rather not touch those as I don't know the file that well.

GUVWAF
GUVWAF approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@GUVWAF GUVWAF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems there was just a hiccup with terrascan. I re-ran the failed jobs and it's fine now.

@wnagele
Copy link
Contributor Author

wnagele commented Dec 27, 2023

@jp-bennett this should be good to merge.

@thebentern thebentern merged commit 06b4638 into meshtastic:master Dec 27, 2023
12 of 14 checks passed
@wnagele wnagele deleted the override_hwid branch December 27, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GUVWAF GUVWAF GUVWAF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wnagele @GUVWAF @thebentern