Initial Partial Updates on t-echo #3090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ixt it currently normal for some e-inks to have faint boot screen yes, a counter but it must goto the rtos tasks i think I dont own a t-echo |
thebentern
reviewed
Jan 16, 2024
| @@ -55,7 +55,7 @@ GxEPD2_BW<TECHO_DISPLAY_MODEL, TECHO_DISPLAY_MODEL::HEIGHT> *adafruitDisplay; | |||
| EInkDisplay::EInkDisplay(uint8_t address, int sda, int scl, OLEDDISPLAY_GEOMETRY geometry, HW_I2C i2cBus) | |||
| { | |||
| #if defined(TTGO_T_ECHO) | |||
| setGeometry(GEOMETRY_RAWMODE, TECHO_DISPLAY_MODEL::WIDTH, TECHO_DISPLAY_MODEL::HEIGHT); | |||
There was a problem hiding this comment.
Is this change necessary?
There was a problem hiding this comment.
I was looking at all the e-ink support as raised by the previous ESP32-S3-PICO PR. I wanted to look at supply these geometry values in the platformio.ini variant files which would reduce the checks so it ok for now
There was a problem hiding this comment.
This was the change actually that made it all work for me (aside from the explicitly partial update parts). The why is an open question to me though
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3075
Partial Updates for t-echo, The boot screen is very faint. And we don't (to my knowledge) do a full refresh at some point to help with ghosting but this should be good for now. I can't believe it was basically working. I'll find some time to write something for full updates (maybe on manual loop of screens and after n-partial updates)