Don't ever delete own node from DB #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebentern
approved these changes
Jan 23, 2024
|
Now with less segfaults! |
The good thing about segfaults is that it clearly indicates an issue in the software and it is easy to pinpoint on a linux system and also to fix. Much better than if issues are silently caught and ignored in the software without any notice. |
mverch67
reviewed
Jan 23, 2024
| @@ -204,6 +204,8 @@ int32_t PositionModule::runOnce() | |||
| } | |||
|
|
|||
| meshtastic_NodeInfoLite *node = nodeDB.getMeshNode(nodeDB.getNodeNum()); | |||
| if (node == nullptr) | |||
| return RUNONCE_INTERVAL; | |||
There was a problem hiding this comment.
Would be way better to also log an error here (instead of silently ignoring the fact that this get function betrayed us).
==> LOG_ERROR("getMeshNode() returned nullptr!");
Imagine we'd have dozens of this kind of code lines in the software where severe problems are simply ignored, how we're gonna pinpoint any bug in the system?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.