Allow NRF52 ADC overrides; begin simplifying analog battery logic #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebentern
approved these changes
Jan 28, 2024
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Jan 28, 2024
Mictronics
referenced
this pull request
in Mictronics/meshtastic_firmware
Feb 2, 2024
…ttery logic (meshtastic#3134)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A special attempt at reducing the ugliness of our getBattVoltage function, which was peppered with preprocessor macros mainly to account for ESP32 platform quirks.
I have broken almost all the ESP32 stuff into its own function, which returns the averaged raw reads.
The nrf52 macro magic happening in the variant.h files really isn't required after this, as far as I can tell. I left them in, until reviewers leave feedback that we can remove them.
The calculation still uses the same numbers, just not hidden behind 3 macros; battery readings won't be impacted.
As a happy side effect, this now allows all nrf52 platforms to use the user-configurable operativeAdcMultiplier.