Restrict MQTT JSON downlink messages #3141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Channel needs to be named "mqtt" "from" field should be set to the node number of the transmitter
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Jan 28, 2024
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Jan 29, 2024
thebentern
approved these changes
Jan 29, 2024
thebentern
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently anyone on an MQTT server can format a JSON message to instruct all nodes with JSON enabled to send out a text or position packet as coming from that node.
With these changes, this is only allowed when the channel is called "mqtt", and the "from" field should be set to the node number of the transmitter (such that only one node transmits).
Also prevented a crash when you didn't specify "altitude" or "time" on a "sendposition" packet.
Furthermore, you can now specify a destination by setting the "to" field to the node number of the receiver.
TODO: documentation needs to reflect these new requirements.