MQTT JSON downlink fixes #3183
Merged
MQTT JSON downlink fixes #3183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GUVWAF
commented
Feb 8, 2024
GUVWAF
commented
- Fixes [Bug]: New MQTT subtopic breaks the logic for parsing the channel when sending JSON. #3168 by looking for the last occurrence of "/" in the topic, instead of the third.
- Allow specifying channel index to send on via LoRa in new JSON field "channel" while still requiring the message to be published to a channel called "mqtt".
Still requires JSON message to be published to channel named "mqtt"
thebentern
approved these changes
Feb 8, 2024
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Feb 8, 2024
|
Latest commit makes it non-breaking: apparently in some places in the documentation another "/" was added after the channel name. |
thebentern
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.