Fix init resolution for all architectures #3184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #endif // ARCH_NRF52 | ||
| analogReadResolution(BATTERY_SENSE_RESOLUTION_BITS); |
There was a problem hiding this comment.
This breaks ESP32 architecture adc readings as it will set the ADC to 10bit when the default value for esp32 is set to 12bit. Fixed in 11d78be
We could also set the ESP32 ADC to 10 bit as 12 bit it's not needed.
code8buster
added a commit
that referenced
this pull request
Feb 12, 2024
Fixed ESP32 ADC resolution bug introduced by #3184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RP2040 was initializing to 10bit adc resolution b/c of the analogReadResolution call being cordoned off by a preprocessor ifdef.
Now fixed, hopefully for all archs