Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rotary encoder #3242

Merged
merged 1 commit into from
Feb 17, 2024
Merged

fix rotary encoder #3242

merged 1 commit into from
Feb 17, 2024

Conversation

mverch67
Copy link
Collaborator

@mverch67 mverch67 commented Feb 17, 2024 •
edited
Loading

spotted a DEBUG_LOG within the rotary encoder interrupt handler code, which causes crashes and lags and which is root cause for #3238

@mverch67 mverch67 requested a review from thebentern February 17, 2024 17:11
@thebentern thebentern merged commit 143ee9c into master Feb 17, 2024
67 checks passed
@thebentern thebentern deleted the rotary-fix branch February 17, 2024 19:26
@andrekir andrekir linked an issue Feb 17, 2024 that may be closed by this pull request
[Bug]: Updates to button click accuracy adversely affect rotary encoders #3238
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code8buster code8buster code8buster approved these changes

@thebentern thebentern thebentern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Updates to button click accuracy adversely affect rotary encoders
3 participants
@mverch67 @thebentern @code8buster