Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds position precision support #3263

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Adds position precision support #3263

merged 5 commits into from
Feb 22, 2024

Conversation

jp-bennett
Copy link
Collaborator

No description provided.

@jp-bennett jp-bennett marked this pull request as ready for review February 22, 2024 18:36
@jp-bennett jp-bennett force-pushed the position-precision-redux branch from 2bbfc1b to 0e34e66 Compare February 22, 2024 19:11
thebentern added a commit to meshtastic/artifacts that referenced this pull request Feb 22, 2024
@jp-bennett jp-bennett merged commit 7706786 into master Feb 22, 2024
67 checks passed
@GUVWAF
Copy link
Member

GUVWAF commented Feb 24, 2024

Since the firmware will just send a packet coming from the client in MeshService::handleToRadio() without modifying the payload, clients are still allowed to let the device send a position packet with arbitrary position which they populate themselves. Do we want to enforce this in the firmware or is it the client's responsibility to use the correct precision for each channel?

@thebentern thebentern deleted the position-precision-redux branch February 24, 2024 13:50
@jp-bennett
Copy link
Collaborator Author

Do we want to enforce this in the firmware

Hmmm. I'm inclined to think we let a client send what it wants. Mainly because implementing this sort of firewall on firmware would be a pain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants