Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More StoreForward updates #3274

Merged
merged 5 commits into from
Feb 25, 2024
Merged

More StoreForward updates #3274

merged 5 commits into from
Feb 25, 2024

Conversation

GUVWAF
Copy link
Member

@GUVWAF GUVWAF commented Feb 24, 2024

  • Set heartbeat broadcast period to 15 min. instead of default_broadcast_interval_secs (which is 12 hours for ROUTER/ROUTER_CLIENT. I thought it was configurable, but it can only be disabled or enabled.
  • Actually disable heartbeat when configured; this->heartbeat was not used. I'm planning to open a PR for the docs to add a tip to disable it once all clients identified the Store & Forward Router, since it's not needed afterwards.
  • Actually check whether historyReturnMax is not yet reached (right now it could cause a buffer overflow).
  • When PSRAM is full, start overwriting it. Still not ideal as you might miss messages that were added at the end, but at least better than doing nothing anymore once you reach it.
  • Require "SF" to be sent as DM to the Store & Forward Router to avoid multiple sending the history at the same time if there are multiple on the mesh.

thebentern added a commit to meshtastic/artifacts that referenced this pull request Feb 24, 2024
thebentern added a commit to meshtastic/artifacts that referenced this pull request Feb 24, 2024
@thebentern thebentern merged commit 02192e1 into meshtastic:master Feb 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants