Refactor EInkDisplay

[todd-herbert]

What

In consultation with @markbirss,

• Merges some variant-specific code
• Shifts macros to respective variant.h files
  Shifts macros to respective platformio.ini files
  Previously tested displays documented at top of EInkDisplay2.cpp
• Change some global variables in EInkDisplay2.cpp to members of the EInkDisplay class
• Purges all "dynamic refresh" code

Why

General tidiness, but also in preparation to re-implement "dynamic refresh" as a derived class of EInkDisplay (easier to maintain, easier to scrap).
More tidying could probably be done. The variant-specific code in connect() has been completely avoid, for fear of breaking something important in some horrible way.

Who this might affect

Heltec Wireless Paper V1.0 reverts to using the stock "full-refresh" E-Ink system of updates.

Minor refactoring affects a large amount of boards. In theory, no changes should be noticed. I'm reasonably sure that everything went into the right variant.h files, but it would be good to get a second pair of eyes on this.

[todd-herbert]

Something spectacular going wrong with one #include. I'll get back to you.

[markbirss]

Something spectacular going wrong with one #include. I'll get back to you.

@todd-herbert

My apologises, I see what is happening I think, in our discord conversation I should have said to include EINK_DISPLAY_MODEL, EPD_HEIGHT and EPD_WIDTH in each variants platformio.ini. (not variant.h)

Eg ESP32-S3-Pico variant

platformio.ini
[env:ESP32-S3-Pico]
-DEINK_DISPLAY_MODEL=GxEPD2_290_T94_V2
-DEPD_HEIGHT=128
-DEPD_WIDTH=296

variant.h
removed

[todd-herbert]

Something spectacular going wrong with one #include. I'll get back to you.

@todd-herbert

My apologises, I see what is happening I think, in our discord conversation I should have said to include EINK_DISPLAY_MODEL, EPD_HEIGHT and EPD_WIDTH in each variants platformio.ini. (not variant.h)

Eg ESP32-S3-Pico variant

platformio.ini [env:ESP32-S3-Pico] -DEINK_DISPLAY_MODEL=GxEPD2_290_T94_V2 -DEPD_HEIGHT=128 -DEPD_WIDTH=296

variant.h removed

Oh right, I see what you meant. I'll make the changes tomorrow.
Do you strongly prefer EPD_HEIGHT over EINK_HEIGHT?

[markbirss]

@todd-herbert

We should use consistent names eg
EINK_DISPLAY_MODEL
EINK_WIDTH
EINK_HEIGHT

[todd-herbert]

Getting a build error for meshtastic-diy-v1, but seems related to 4ffb906

[markbirss]

changes look good, just update the variant.h files as we only need them defined in platformio.ini not both

[todd-herbert]

changes look good, just update the variant.h files as we only need them defined in platformio.ini not both

Oh jeez.. I absolutely did do all that, but somehow I've made a horrible mess of the commit..
Very grateful that you spotted that..

[todd-herbert]

Lesson learnt: double check, and then check again. Can't apologize enough for turning what should have been a simple task into a saga.

[markbirss]

Lesson learnt: double check, and then check again. Can't apologize enough for turning what should have been a simple task into a saga.

yes, these things happen

[markbirss]

@todd-herbert t-echo trunk issue ?

[todd-herbert]

@todd-herbert t-echo trunk issue ?

Huh.. weird. It has only popped up after this latest commit. I'm out of the house right now but I'll look into it in a little bit.