Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement "Dynamic E-Ink" as a derived class #3316

Merged
merged 3 commits into from
Mar 3, 2024
Merged

Reimplement "Dynamic E-Ink" as a derived class #3316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
517ed49
Reimplement "Dynamic E-Ink" as a derived class
todd-herbert Mar 2, 2024
2d89a52
Merge branch 'master' into EInkDynamicDisplay
thebentern Mar 2, 2024
b2871a2
Merge branch 'master' into EInkDynamicDisplay
thebentern Mar 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/graphics/EInkDisplay2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,9 @@ bool EInkDisplay::forceDisplay(uint32_t msecLimit)
#ifndef EINK_NO_HIBERNATE // Only hibernate if controller IC will preserve image memory
// Put screen to sleep to save power (possibly not necessary because we already did poweroff inside of display)
adafruitDisplay->hibernate();
LOG_DEBUG("done\n");
#endif

LOG_DEBUG("done\n");
return true;
}

Expand Down
4 changes: 3 additions & 1 deletion src/graphics/EInkDisplay2.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
/**
* An adapter class that allows using the GxEPD2 library as if it was an OLEDDisplay implementation.
*
* Note: EInkDynamicDisplay derives from this class.
*
* Remaining TODO:
* optimize display() to only draw changed pixels (see other OLED subclasses for examples)
* implement displayOn/displayOff to turn off the TFT device (and backlight)
Expand Down Expand Up @@ -41,7 +43,7 @@ class EInkDisplay : public OLEDDisplay
*
* @return true if we did draw the screen
*/
bool forceDisplay(uint32_t msecLimit = 1000);
virtual bool forceDisplay(uint32_t msecLimit = 1000);

/**
* shim to make the abstraction happy
Expand Down
Loading
Loading