Refactor paxcounter #3351
Merged
Refactor paxcounter #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caveman99
requested changes
Mar 8, 2024
| @@ -31,9 +49,12 @@ bool PaxcounterModule::sendInfo(NodeNum dest) | |||
| meshtastic_MeshPacket *p = allocDataProtobuf(pl); | |||
| p->to = dest; | |||
| p->decoded.want_response = false; | |||
| p->priority = meshtastic_MeshPacket_Priority_MIN; | |||
| p->priority = meshtastic_MeshPacket_Priority_DEFAULT; | |||
There was a problem hiding this comment.
Please leave this as min, regular message traffic should have priority.
There was a problem hiding this comment.
ok, no problem.
Just a question: When would BACKGROUND be appropriate?
There was a problem hiding this comment.
Pretty well explained in https://github.com/meshtastic/protobufs/blob/00332412b238fe559175a6e83fdf8d31fa5e209a/meshtastic/mesh.proto#L819-L878 ... I think BACKGROUND may be more appropriate than MIN here, and in other places that use it. (Telemetry and so on...) For now i'd stick to min cause the other plugins use min too. Let's address this in a different PR.
caveman99
approved these changes
Mar 10, 2024
caveman99
force-pushed
the
refactor-paxcounter
branch
from
7a9a1cf to
d1b6cc4
Compare
…late (count mode != 1); use flag to signal changed count data
caveman99
force-pushed
the
refactor-paxcounter
branch
from
d1b6cc4 to
26691c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #3342 (using timesliced count, not yet configurable)