Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been testing LTO cells recently and noticed that the SoC values didn't make much sense.
Upon a closer look the values for the discharge curve are far off from what a typical LTO discharge curve looks like. Here I put in the current curve (red dots) to visualise this for myself:
This PR changes the curve to the values from this graph (1C) which in turn result in reasonable SoC values.
I did a cursory check on the other chemistries and they don't seem to suffer the same issue. So I guess some wrong discharge curve was used to deduct those values from maybe?