Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tryfix T-Echo rollback variant #3406

Closed
wants to merge 3 commits into from
Closed

Tryfix T-Echo rollback variant #3406

wants to merge 3 commits into from

Conversation

thebentern
Copy link
Contributor

@thebentern thebentern commented Mar 14, 2024

No description provided.

@andrekir
Copy link
Member

we need to keep PIN_POWER_EN, the only change introduced in the setup() is PIN_POWER_EN1.

testing this in here: 8303a41

@andrekir
Copy link
Member

cause for #3390 looks like pin map conflicts across different board revisions.

#define PIN_LED1 (0 + 14) // blue (confirmed on boards marked v1.0, date 2021-6-28)
#define PIN_LED2 (32 + 1) // green
#define PIN_LED3 (32 + 3) // red
#define PIN_LED1 (0 + 14) // blue (confirmed on ? board)
#define PIN_LED2 (0 + 15) // green
#define PIN_LED3 (0 + 13) // red

the safe approach for now is to just comment out PIN_POWER_EN1 used in the code.

@thebentern let me know if you want to have the changes from 8303a41 made here, or use PR #3375

@thebentern
Copy link
Contributor Author

the safe approach for now is to just comment out PIN_POWER_EN1 used in the code.

@thebentern let me know if you want to have the changes from 8303a41 made here, or use PR #3375

Sure, let's try it. :-)

@thebentern thebentern closed this Mar 15, 2024
@thebentern thebentern deleted the t-echo-rollback branch March 15, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants