Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More comprehensive client proxy queue guards #3414

Merged
merged 13 commits into from
Mar 15, 2024
Merged

Conversation

thebentern
Copy link
Contributor

From a call with @mc-hamster ;-)

src/mqtt/MQTT.cpp Outdated Show resolved Hide resolved
src/mesh/PhoneAPI.cpp Outdated Show resolved Hide resolved
@thebentern thebentern requested a review from GUVWAF March 14, 2024 23:14
@thebentern thebentern changed the title More comprehensive MQTT thread and client proxy queue guards More comprehensive client proxy queue guards Mar 14, 2024
Copy link
Member

@caveman99 caveman99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments in discussion

@thebentern thebentern requested review from GUVWAF and caveman99 March 15, 2024 16:32
@thebentern
Copy link
Contributor Author

See comments in discussion

Tested on my device. MQTT starts up like a champ after channels change to have uplink/downlink

thebentern added a commit to meshtastic/artifacts that referenced this pull request Mar 15, 2024
@thebentern thebentern merged commit 52cfec2 into master Mar 15, 2024
70 checks passed
@thebentern thebentern deleted the additional-mqtt-guard branch March 15, 2024 21:17
upchui added a commit to upchui/firmware-Meshtastic-Unleashed that referenced this pull request Mar 16, 2024
* (1/3) Support L76B GNSS chip found on pico waveshare shield. Original work by @Mictronics

* NodeInfo broadcast ensure default on 0 and enforce 1 hour minimum (meshtastic#3415)

* NodeInfo broadcasts ensure defaults on 0 and enforce 1 hour minumum

* Doh!

* Hey that's not on config!

* We don't use Lorawan (meshtastic#3417)

#warning "Persistent storage not supported!" [-Wcpp]

* [create-pull-request] automated change (meshtastic#3418)

Co-authored-by: thebentern <[email protected]>

* fix compilation

* don't fix this to a hardware model.

* new Accelerometer lib (meshtastic#3413)

* new Accelerometer lib

* Use our fork till upstreasm merges changes.

* that PR escalated quickly

* resurrect display flip

* that should work now

* (2/3) Add Slow Clock Support for RP2040 platform. This will disable USB Softserial.

* More comprehensive client proxy queue guards (meshtastic#3414)

* More comprehensive MQTT thread and queue guards

* Consolidate logic

* Remove channel check

* Check for map_reporting_enabled as well

* Update message

* Remove channel check from here as well

* One liner

* Start the mqtt thread back up when channels change and we want mqtt

* fix for I2C scan getting stuck (meshtastic#3375)

* refactor: add delay for T-Echo peripherals setup

* comment out `PIN_POWER_EN1`

* [create-pull-request] automated change (meshtastic#3419)

Co-authored-by: thebentern <[email protected]>

* Handle for heartbeat toradio packets (meshtastic#3420)

* Factory reset GNSS_MODEL_MTK GPS modules with PCAS10,3 (meshtastic#3388)

Co-authored-by: Ben Meadors <[email protected]>

* [create-pull-request] automated change (meshtastic#3422)

Co-authored-by: thebentern <[email protected]>

* (3/3) Add variant for pico with waveshare and GPS hat (meshtastic#3412)

* (3/3) Add variant for pico with waveshare and GPS hat, utilizing slow clock.

* Not everybody has Serial2

* Trunk

* Push it real gud

* No init

---------

Co-authored-by: Ben Meadors <[email protected]>

---------

Co-authored-by: Thomas Göttgens <[email protected]>
Co-authored-by: Ben Meadors <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: thebentern <[email protected]>
Co-authored-by: Andre K <[email protected]>
Co-authored-by: David Ellefsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants