Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native: fail-safes for simulated node without config file #3486

Merged
merged 2 commits into from
Mar 24, 2024

Conversation

GUVWAF
Copy link
Member

@GUVWAF GUVWAF commented Mar 24, 2024

When trying to run multiple simulated nodes without config file on my Ubuntu system, I experienced two crashes. The first one was because settingsMap[maxnodes] was not defined. Second one was because LinuxInput was closing file descriptor 0 when rebooting and after boot psock in WiFiServer got assigned to 0, which lead to an assert.

I also set the default log level to debug.

@GUVWAF GUVWAF requested a review from jp-bennett March 24, 2024 16:04
Copy link
Collaborator

@jp-bennett jp-bennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good catches!

@thebentern thebentern merged commit 77fb230 into meshtastic:master Mar 24, 2024
69 checks passed
@GUVWAF GUVWAF deleted the nativeSim branch September 28, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants