Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reboot for non-radio lora config changes #3505

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

thebentern
Copy link
Contributor

Closes #3504

@thebentern thebentern requested a review from caveman99 March 28, 2024 21:41
@jp-bennett
Copy link
Collaborator

I like it. But I suspect we'll find edge cases for a while to come, where parts of the firmware is written with the assumption that settings never change.

@thebentern
Copy link
Contributor Author

I like it. But I suspect we'll find edge cases for a while to come, where parts of the firmware is written with the assumption that settings never change.

I did a deep dive. Everything right now just reads from the updated values in lora config, so we should be fine. The only thing that needs the reboot within this section are settings which affect the RadioLib init of the radio.

@thebentern thebentern merged commit daa4d38 into master Mar 28, 2024
70 checks passed
@thebentern thebentern deleted the lora-reboot branch March 28, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Admin Message for ignore incoming that does not require a reboot
2 participants