Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Linux Build (ARM support and webserver deps) #3506

Merged

Conversation

jaredquinn
Copy link
Contributor

@jaredquinn jaredquinn commented Mar 29, 2024

Changes to support Docker on ARM

  • Use bookworm-slim rather than previous base image which was only supported on x64
  • Copy resulting target architecture binary to meshtasticd

Changes to include webserver dependencies in default Linux Native builds.

  • Update apt-install calls to include -dev and binary versions of the libraries in the appropriate builds
  • Use current working directory for build rather than pulling down the current master branch from github and only building that.

Updated Dockerfile tested against v2.2.9 and current master.
Additionally fixes #3499

As discussed with @jp-bennett on discord.

arch/portduino/portduino.ini Outdated Show resolved Hide resolved
@jaredquinn jaredquinn marked this pull request as ready for review March 29, 2024 00:59
Copy link
Contributor

github-actions bot commented Mar 29, 2024

🤖 Pull request artifacts

empty string

file commit
firmware-2.3.4.e00536c.zip e00536c

thebentern added a commit to meshtastic/artifacts that referenced this pull request Mar 29, 2024
thebentern added a commit to meshtastic/artifacts that referenced this pull request Mar 29, 2024
thebentern added a commit to meshtastic/artifacts that referenced this pull request Mar 29, 2024
thebentern added a commit to meshtastic/artifacts that referenced this pull request Apr 5, 2024
@jaredquinn jaredquinn changed the title Native build default webserver Native Linux Build (ARM build and default webserver deps) Apr 6, 2024
@jaredquinn jaredquinn changed the title Native Linux Build (ARM build and default webserver deps) Native Linux Build (ARM support and webserver deps) Apr 6, 2024
@jaredquinn
Copy link
Contributor Author

Added trunk-check ignores for terrascan/AC_DOCKER_0002; it currently seems to provide false-positives on RUN apt-get:

tenable/terrascan#977

Added ignores for hadolint/DL3008 - ideally we want the container to stay up to date with platform packages; I see no reason to pin build dependencies here.

@thebentern thebentern merged commit 0e9f1be into meshtastic:master Apr 6, 2024
69 checks passed
@jaredquinn jaredquinn deleted the native-build-default-webserver branch April 6, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Linux native docker build fails on ARM
3 participants