Add keymappings for several utility functions #3536

caveman99 · 2024-04-02T12:51:34Z

map fn+m to mute and unmute the external notification module
map fn+t to be an alternative for the TAB key
map fn+g to toggle GPS mode
map fn+space to send network ping

for @tropho23 with ❤️

tropho23 · 2024-04-02T15:43:34Z

Excellent, thank you!! I will test this change this evening after work, assuming someone else doesn't beat me to it 🙂 Tony Good

…

________________________________ From: Thomas Göttgens ***@***.***> Sent: Tuesday, April 2, 2024 08:51 To: meshtastic/firmware ***@***.***> Cc: tropho23 ***@***.***>; Mention ***@***.***> Subject: [meshtastic/firmware] Mute external notifications from keyboard (PR #3536) * map fn+m to mute and unmute the external notification module * map fn+t to be an alternative for the TAB key for @tropho23<https://github.com/tropho23> with ❤️

________________________________ You can view, comment on, or merge this pull request online at: #3536 Commit Summary * 2e26efe<2e26efe> - map fn+m to mute and unmute the external notification module File Changes (3 files<https://github.com/meshtastic/firmware/pull/3536/files>) * M src/modules/CannedMessageModule.cpp<https://github.com/meshtastic/firmware/pull/3536/files#diff-caf0a45c5c8826739fb7f9d175b3867d8a7c7a2d8709457f96a8c271a10ddcb8> (15) * M src/modules/ExternalNotificationModule.cpp<https://github.com/meshtastic/firmware/pull/3536/files#diff-8f0f833122f0577cc7d091d7954100cba2e48c1208d118f5830f68417eace402> (4) * M src/modules/ExternalNotificationModule.h<https://github.com/meshtastic/firmware/pull/3536/files#diff-9ff83e2a3de8cfc6dbf0dfb19a3242ee3058939b69c33d00ec005e5c4ba33c96> (5) Patch Links: * https://github.com/meshtastic/firmware/pull/3536.patch * https://github.com/meshtastic/firmware/pull/3536.diff — Reply to this email directly, view it on GitHub<#3536>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQ7GUPWS2UE5BQIAWES5UBLY3KSWXAVCNFSM6AAAAABFTKTAH6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZDANBUHAYDIMA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

rcarteraz · 2024-04-02T19:46:13Z

src/modules/CannedMessageModule.cpp

@@ -397,6 +398,7 @@ int32_t CannedMessageModule::runOnce()
                }
                break;
            case 0x09: // tab
+            case 0x91: // fn+t for T-Deck that doesn't have a tab key


T-Deck doesn't have a fn key either, it has an alt key.

Alt is mapped to Fn in the t-deck driver... Since cardkb does not have an alt key and sym+t is / (forward slash)

Hmm. I tried this on my T-Deck and the alt + t did nothing for me.

yes, because of the other bug... whitelist was not updated.

Gotcha... I'll try again when the artifacts are ready.

Just tried the artifact from the latest change and alt+t still doesn't work as tab for the T-Deck 😞

anything helpful in debug log?

Nada... It doesn't seem the alt is engaging the fn aspect because all it's doing is typing 't'.

I had a look at the 'probably used' ESP32-C3 keyboard firmware of the T-Deck and it's nothing like the cardkb at all. It looks more like the code used in the BB10 Keyboard, where you have to manage the alt and sym presses yourself. When you press alt, then t, what scancode(s) is/are printed in the debug log?

I don't think that level of logging is turned on as I don't see the scan code.

DEBUG | 14:24:30 73 [cardKB] Canned message event any key pressed DEBUG | 14:24:30 73 [cardKB] showing standard frames DEBUG | 14:24:30 73 [cardKB] Module wants a UI Frame DEBUG | 14:24:30 73 [cardKB] Showing 1 module frames DEBUG | 14:24:30 73 [cardKB] Total frame count: 104 DEBUG | 14:24:30 73 [cardKB] Added modules. numframes: 1 DEBUG | 14:24:30 73 [cardKB] Finished building frames. numframes: 8

tropho23 · 2024-04-02T23:04:02Z

These changes don't work for me; compiled and uploaded to RAK4631 with CardKB, RAK buzzer, external vibramotor and Fn+M (or pressing Fn so the onboard Neopixel flashes green, then pressing M) does not disable the External Notifications module. Same issue with Fn+T, which does not invoke the channel select menu like pressing TAB does.

I also tried changing the key scan codes to see if different ones would work, but they did not.

HarukiToreda · 2024-04-03T07:14:51Z

I was able to get it working by adding this line "case 0xac: // fn+m" on line 221 of src>input>kbl2cBase.cpp>runOnce()

HarukiToreda · 2024-04-03T16:42:28Z

also must change line 426 in src>module>CannedMessageModule.cpp>runOnce() to "if (moduleConfig.external_notification.enabled = true) {"

caveman99 · 2024-04-03T17:09:59Z

also must change line 426 in src>module>CannedMessageModule.cpp>runOnce() to "if (moduleConfig.external_notification.enabled = true) {"

"== true", right? or you will set it to true...

tropho23 · 2024-04-04T00:26:56Z

The changes from today make Fn+M work to toggle notifications, thanks! I did notice that once I press M (after pressing Fn and see the green LED flashing to include the function key was pressed), notifications are muted but also the device thinks I am starting to type a message, as the message input screen is displayed as if I typed a regular letter. If it does not do that it will work perfectly :)

HarukiToreda · 2024-04-04T03:21:02Z

The changes from today make Fn+M work to toggle notifications, thanks! I did notice that once I press M (after pressing Fn and see the green LED flashing to include the function key was pressed), notifications are muted but also the device thinks I am starting to type a message, as the message input screen is displayed as if I typed a regular letter. If it does not do that it will work perfectly :)

That's a simple fix, just add "runState = CANNED_MESSAGE_RUN_STATE_INACTIVE;" on lines 429 and 433 so that it keeps the text entry to not activate. @caveman99

- map fn+t to be an alternative for the TAB key

tropho23 · 2024-04-04T17:49:08Z

All of these work perfectly, thank you @caveman99 and @HarukiToreda

tropho23 · 2024-04-04T17:50:49Z

Also I will submit a feature request to add some screen 'toast' (popup) messages that indicate what the hotkey did.

thebentern · 2024-04-06T13:05:58Z

Are we good to merge this one now?

HarukiToreda · 2024-04-06T16:44:04Z

Are we good to merge this one now?

From my testing, all functions work. I believe it's good to merge.

mverch67 · 2024-04-12T08:34:00Z

Can we add all the keymappings into the documentation, e.g. here:
https://meshtastic.org/docs/hardware/devices/tdeck

rcarteraz · 2024-04-12T16:20:48Z

Can we add all the keymappings into the documentation, e.g. here: https://meshtastic.org/docs/hardware/devices/tdeck

Probably not best there as these are specific to the CardKB. They do not work on the T-Deck. At least I've been unable to make them work.

GeneralZodGit · 2024-04-17T12:44:25Z

I am running firmware 2.3.4 and the ALT + KEY on the T-Deck doesn't work Only ALT-B for the keyboard backlight.

tropho23 · 2024-04-17T13:26:44Z

If I recall correctly, the ALT+key combos for T-Deck cannot be mapped by users so we must consider SYM+ combos. This presents an issue since the SYM key is used to enter symbols, and every mappable key already has a symbol that is needed. If only the T-Deck keyboard wasn't so limited... Tony Good

…

________________________________ From: GeneralZodGit ***@***.***> Sent: Wednesday, April 17, 2024 08:44 To: meshtastic/firmware ***@***.***> Cc: tropho23 ***@***.***>; Mention ***@***.***> Subject: Re: [meshtastic/firmware] Add keymappings for several utility functions (PR #3536) I am running firmware 2.3.4 and the ALT + KEY on the T-Deck doesn't work Only ALT-B for the keyboard backlight. — Reply to this email directly, view it on GitHub<#3536 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQ7GUPU2EFU66GR4OXPKBELY5ZVEDAVCNFSM6AAAAABFTKTAH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRGE3TKNZXHA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

rcarteraz reviewed Apr 2, 2024

View reviewed changes

caveman99 force-pushed the mute-notifications branch from 2e26efe to 61d7ef1 Compare April 3, 2024 17:04

caveman99 changed the title ~~Mute external notifications from keyboard~~ Add keypappings for several utility functions Apr 4, 2024

caveman99 changed the title ~~Add keypappings for several utility functions~~ Add keymappings for several utility functions Apr 4, 2024

caveman99 added 5 commits April 4, 2024 11:00

- map fn+m to mute and unmute the external notification module

ca188d1

- map fn+t to be an alternative for the TAB key

add whitelist to inputbroker

b1ef922

(maybe) sweet-talking t-deck into tabbing...

4f7f198

now for real - back in Kansas

1b0c905

More fancy mappings

3dee22b

caveman99 force-pushed the mute-notifications branch from 4e27351 to 3dee22b Compare April 4, 2024 09:00

Merge branch 'master' into mute-notifications

c309c9e

tropho23 mentioned this pull request Apr 4, 2024

[Feature Request]: Add display messages on device screen following feature toggle #3551

Closed

Merge branch 'master' into mute-notifications

a981b1f

Merge branch 'master' into mute-notifications

ccf585b

thebentern merged commit 1baad28 into master Apr 7, 2024
70 checks passed

thebentern deleted the mute-notifications branch April 7, 2024 00:13

mverch67 mentioned this pull request Apr 12, 2024

Add T-Deck key mapping to documentation meshtastic/meshtastic#1184

Closed

mverch67 mentioned this pull request Apr 13, 2024

[Bug]: T-Deck canned messages only send to primary channel #3543

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add keymappings for several utility functions #3536

Add keymappings for several utility functions #3536

caveman99 commented Apr 2, 2024 •

edited

Loading

tropho23 commented Apr 2, 2024 via email

rcarteraz Apr 2, 2024

caveman99 Apr 3, 2024

rcarteraz Apr 3, 2024

caveman99 Apr 3, 2024

rcarteraz Apr 3, 2024

rcarteraz Apr 3, 2024

caveman99 Apr 3, 2024

rcarteraz Apr 3, 2024

caveman99 Apr 4, 2024

rcarteraz Apr 4, 2024

tropho23 commented Apr 2, 2024 •

edited

Loading

HarukiToreda commented Apr 3, 2024

HarukiToreda commented Apr 3, 2024

caveman99 commented Apr 3, 2024

tropho23 commented Apr 4, 2024

HarukiToreda commented Apr 4, 2024

tropho23 commented Apr 4, 2024

tropho23 commented Apr 4, 2024

thebentern commented Apr 6, 2024

HarukiToreda commented Apr 6, 2024

mverch67 commented Apr 12, 2024

rcarteraz commented Apr 12, 2024

GeneralZodGit commented Apr 17, 2024

tropho23 commented Apr 17, 2024 via email

Add keymappings for several utility functions #3536

Add keymappings for several utility functions #3536

Conversation

caveman99 commented Apr 2, 2024 • edited Loading

tropho23 commented Apr 2, 2024 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tropho23 commented Apr 2, 2024 • edited Loading

HarukiToreda commented Apr 3, 2024

HarukiToreda commented Apr 3, 2024

caveman99 commented Apr 3, 2024

tropho23 commented Apr 4, 2024

HarukiToreda commented Apr 4, 2024

tropho23 commented Apr 4, 2024

tropho23 commented Apr 4, 2024

thebentern commented Apr 6, 2024

HarukiToreda commented Apr 6, 2024

mverch67 commented Apr 12, 2024

rcarteraz commented Apr 12, 2024

GeneralZodGit commented Apr 17, 2024

tropho23 commented Apr 17, 2024 via email

caveman99 commented Apr 2, 2024 •

edited

Loading

tropho23 commented Apr 2, 2024 •

edited

Loading