Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore MQTT by default and then don't transmit downlink over LoRa #3591

Closed
wants to merge 1 commit into from

Conversation

GUVWAF
Copy link
Member

@GUVWAF GUVWAF commented Apr 10, 2024

This implements what has been discussed up till now in meshtastic/rfcs#9 and thus needs to be approved first.
The "ignore MQTT" LoRa setting will be enabled by default and this now also means if you have MQTT downlink enabled, it doesn't transmit these packets over LoRa. MQTT-only will work as before and if you also want your mesh to receive the downlinks, you have to explicitly disable "ignore MQTT".

Tested both that MQTT downlink works and also ignoring MQTT works as before.

@tropho23
Copy link
Contributor

tropho23 commented May 7, 2024

Wonderful! I just submitted a feature request with this exact suggestion, and tagged your PR as a probably solution to get it some attention.

@thespillmonkey
Copy link

with this change, if disabled on the radio connected to the broker, after an mqtt packet makes it's hop from the broker to the radio and gets transmitted to the mesh, will it then continue to hop just like a normal packet, or will it continue relaying on other radios if they have this enabled? Or is it "flagged" in some way as an mqtt packet and wont be relayed?

@fifieldt
Copy link
Contributor

Is this still needed after dontMQTTMebro?

@GUVWAF
Copy link
Member Author

GUVWAF commented Sep 17, 2024

This is the other way around: packets from MQTT (downlink) can be controlled to not be transmitted over LoRa. Just like the public MQTT server is currently doing with zero-hopping, but then enforced on the firmware, such that it also holds for private MQTT servers.

@thebentern thebentern closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants