Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CDEBYTE_EoRa-S3 #3613

Merged
merged 13 commits into from
Apr 16, 2024
Merged

Conversation

S5NC
Copy link
Contributor

@S5NC S5NC commented Apr 13, 2024

This board is a clone of the T3S3 V1.2, however it uses XTAL instead of TCXO, so it needs a new variant...
It uses the ESP32-S3FH4R2 (like the T3S3)

  • Find out which name CDEBYTE prefers to ensure no future conflicts with their other products - No response, so if there are future conflicts it's on them!
  • I set the dedicated UART pins to be UART, so the 1mm JST SH connector closest to the USB-C port will be for UART.
  • I set the 1mm JST SH connector furthest from the USB-C port which follows the most common I2C layout to I2C.
  • boards json file
    • I don't fully know what in here is needed or not
    • I haven't checked yet to see if the boards file is optimal for it, to make use of its PSRAM, RAM, flash, etc. nor the CDC and USB mode settings - I just copied T3S3 variant.
  • variant.h
    • SD card - copied from T3S3 and untested
    • ADC configuration - tested, 2.00 as the scaler gives an accurate value. This makes sense as the voltage divider consists of two 1 MΩ resistors in series, tapped where they meet. I left the extra 0.11 from the T3S3, as margin, although I don't believe that this should be the way we do things.
    • I2C on the other port - untested, see comment under pins_arduino.h
  • platformio.ini
    • I don't know what in here is needed or not, like board_level = extra nor whether -D GPS_POWER_TOGGLE is needed in build options. I keep the GPS_POWER_TOGGLE because it is in the T3S3 variant.
  • pins_arduino.h
    • I don't fully know what in here is needed or not
    • Do we really need to define the hardware IDs in this file and also in the board json file?!
    • I don't think we also need to set pins for the second I2C interface in this file, I believe I2C pins in this file are only used as defaults for certain sensors, and they probably are later changed.
    • I'm not sure if the way the pins are counted is correct in the < ? clause, however it is functional and like that in this file for other variants.

Copy link
Contributor

🤖 Pull request artifacts

empty string

file commit
firmware-2.3.5.3216374.zip bf8634d

thebentern added a commit to meshtastic/artifacts that referenced this pull request Apr 14, 2024
@rcarteraz
Copy link
Member

Do you have this device and have tested it?

@S5NC
Copy link
Contributor Author

S5NC commented Apr 15, 2024

Do you have this device and have tested it?

It has been tested with someone who has the device, albeit with -D PRIVATE_HW instead of -D CDEBYTE_EORA_S3 in platformio.ini, as the protobuf does not yet exist.

@S5NC S5NC marked this pull request as ready for review April 15, 2024 21:25
@S5NC
Copy link
Contributor Author

S5NC commented Apr 15, 2024

Waiting on meshtastic/protobufs#484

@thebentern thebentern merged commit e813703 into meshtastic:master Apr 16, 2024
70 checks passed
@S5NC S5NC deleted the CDEBYTE_EoRa-S3 branch April 16, 2024 17:25
@meshtastic-bot
Copy link

This pull request has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/ebyte-e22-900mm22s-the-same-as-sx1262/11041/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants