Added one minute throttling to NodeDB save to disk #3648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebentern
added a commit
to meshtastic/artifacts
that referenced
this pull request
Apr 16, 2024
GUVWAF
approved these changes
Apr 18, 2024
|
Can the throttling be responsible for some position jumping while doing live tracking using mesh network with LoRa. During my test i found some jumping in the position of nodes while tracking. I have attached the video .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prevent the hammering of the file system on large meshes (public mqtt included). I ran a test earlier on the msh/US root and experienced 13 nodedb saves to disk within about a one minute period. It is likely responsible for some of the issues with nodes "loosing settings".
I have plans for a more uses of the generic throttle methods. A follow up PR to refactor smart position will utilize it.