Support radar sensor RCWL-9620 on i2c #3678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebentern
approved these changes
Apr 20, 2024
|
ARM runner still FUBAR |
|
Would be fair to say that the ARM runner needs a HAND? |
|
it needs to be put out of its misery ... :-) |
|
Hi @caveman99, I think /src/serialization/MeshPacketSerializer.cpp and possibly the nRF version of this file would need the meshtastic_PortNum_TELEMETRY_APP section updated to actually put the distance out into transmitted protobufs. Let me know if a separate issue should be raised. |
|
@ndoo thanks for your detailed analysis. Please do raise a separate issue so we don't lose this important information :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs PR from Protos repo to compile.