Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed node and channel selection for t-deck #3695

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

nbaddorf
Copy link
Contributor

To change nodes and channels, press the tab button (use a modifier key) to change nodes. Press it again to toggle to the channel selection.

(for a tab modifier key for the t-deck checkout my other pull request: #3668)

This enables the node and channel selection to be accessed by pressing the tab shortcut and then swiping between nodes or pressing tab again to change channels.

(To access the tab function look at my other pull request meshtastic#3668)
Copy link
Member

@caveman99 caveman99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 100% sure about that one. I remember them being there for a reason. Maybe talk to @mverch67 about that PR

@thebentern thebentern requested a review from mverch67 April 22, 2024 14:14
@mverch67
Copy link
Collaborator

not 100% sure about that one. I remember them being there for a reason. Maybe talk to @mverch67 about that PR

Yes, it's ok. These lines were in place to automatically enter the node selection mode when swiping left/right due to a missing tab key. Now that a tab key is simulated on T-Deck these lines can be removed.

@nbaddorf
Copy link
Contributor Author

Great thanks!

@nbaddorf nbaddorf requested a review from caveman99 April 23, 2024 12:02
@thebentern thebentern merged commit d0e81b9 into meshtastic:master Apr 23, 2024
66 checks passed
@meshtastic-bot
Copy link

This pull request has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/t-deck-firmware-2-3-7-2-3-8/12460/5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants