Optimization: stop relaying when reply is received #3753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small optimization to stop relaying a direct message not only when it’s ACKed, but also when the recipient has already replied to it (e.g. for traceroute and position requests). Nodes might have the packet to be relayed still in their Tx queue when they receive the reply. At that point we can cancel this transmission.
Tested with a traceroute from 0 to 2 in the interactive simulator. On the left is the current master where node 1 relays both the request and reply. On the right is this PR where it only relays the reply (although it was received directly but node 0 doesn’t ACK the reply).