Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #MESHTASTIC_EXCLUDE_ENVIRONMENTAL_SENSOR #3776

Conversation

oseiler2
Copy link
Contributor

@oseiler2 oseiler2 commented May 3, 2024

Ensure that #define MESHTASTIC_EXCLUDE_ENVIRONMENTAL_SENSOR actually excludes the sources of all environmental sensors, so that the lib dependencies do not need to be pulled in.

Also moved QMC5883LCompass under [environmental_base]

Fixed compile error when MESHTASTIC_EXCLUDE_GPS defined (CannedMessageModule)

see #3734

@oseiler2
Copy link
Contributor Author

oseiler2 commented May 3, 2024

I'm new to trunk - it's not raising any issues in my VS Code environment and I can't see anything obvious why some files are failing. Any pointers as to what it's complaining about?

@thebentern
Copy link
Contributor

You can manually run trunk fmt. Looks like it's just complaining about whitespace / styling issues

@caveman99
Copy link
Member

You can manually run trunk fmt. Looks like it's just complaining about whitespace / styling issues

trunk is now supported on windows. so the vscode plugin actually works. just it's missing a few formatters compared to the linux version. notably clang-format. so people on windows get the thumbs up from the plugin and CI still complains.

@thebentern
Copy link
Contributor

Ah yes. I've been running trunk manually on my windows box inside WSL.

@caveman99
Copy link
Member

Ah yes. I've been running trunk manually on my windows box inside WSL.

me too but i see this pop up a lot lately. How feasible is a 'trunk fmt, then push to pr' ci action to run manually?

@caveman99 caveman99 merged commit df3cceb into meshtastic:master May 3, 2024
70 checks passed
@oseiler2
Copy link
Contributor Author

oseiler2 commented May 5, 2024

Weird, I thought trunk was happy (screenshot is on the file version that the runner complained about), and I have run trunk fmt in terminal without it showing any errors. Appreciate any pointers to get this resolved.
image

@oseiler2 oseiler2 deleted the fix/MESHTASTIC_EXCLUDE_ENVIRONMENTAL_SENSOR branch October 18, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants