-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #MESHTASTIC_EXCLUDE_ENVIRONMENTAL_SENSOR #3776
Fix #MESHTASTIC_EXCLUDE_ENVIRONMENTAL_SENSOR #3776
Conversation
I'm new to trunk - it's not raising any issues in my VS Code environment and I can't see anything obvious why some files are failing. Any pointers as to what it's complaining about? |
You can manually run |
trunk is now supported on windows. so the vscode plugin actually works. just it's missing a few formatters compared to the linux version. notably clang-format. so people on windows get the thumbs up from the plugin and CI still complains. |
Ah yes. I've been running trunk manually on my windows box inside WSL. |
me too but i see this pop up a lot lately. How feasible is a 'trunk fmt, then push to pr' ci action to run manually? |
Ensure that
#define MESHTASTIC_EXCLUDE_ENVIRONMENTAL_SENSOR
actually excludes the sources of all environmental sensors, so that the lib dependencies do not need to be pulled in.Also moved QMC5883LCompass under [environmental_base]
Fixed compile error when MESHTASTIC_EXCLUDE_GPS defined (CannedMessageModule)
see #3734