Enable compiling with gccnoneeabi 12.3.1 for nRF52 targets, additional small fixes #3778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
Another uint in GPS.cpp |
Type of nodeNum is NodeNum, not uint
Missing include breaks compilation with gccnoneeabi 12.3.1 for nrf52 targets on windows hosts.
uint is not a standard type. Using uint breaks compilation with gccnoneeabi 12.3.1 for nRF52 targets on windows hosts.
Type of channel_num should be uint32_t (as this is the type of hash() and numChannels). Using uint non-standard type uint breaks compilation with gccnoneeabi 12.3.1 for nRF52 targets on windows hosts.
Default build type should be "release" as this is the default of platformio.
uint to unsigned int
caveman99
approved these changes
May 3, 2024
|
I have the same changes in an uncommitted branch where i wanted to try something out. absolutely spot on ... thanks |
|
I remember now where these changes were needed. ESP32-C6 support requires a newer ESP32 toolchain, and this one complained about the same defines, among other things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with gccnoneeabi 12.3.1 (on windows) one runs into the problem that there are some definitions using the type "uint", which is not a standard type. Resulting in a failed compiler run.
Also there are two instances of a missing time.h (error: time_t not declared).
The meshtastic type of nodeNum is "NodeNum", so it should be used instead of uint.
channel_num is defined as uint, but should rather be uint32_t (type of hash() and num_channels)
Typo "Adverising" fixed in nrf/bluetooth