Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sensirion SHT4X sensors #3792

Merged
merged 9 commits into from
May 8, 2024
Merged

Add Sensirion SHT4X sensors #3792

merged 9 commits into from
May 8, 2024

Conversation

pr000t
Copy link
Contributor

@pr000t pr000t commented May 5, 2024

Add SHT45 sensor.
For the SHT40 and SHT41, the registerValue in ScanI2CTwoWire.cpp need to be added.

platformio.ini Outdated Show resolved Hide resolved
src/mesh/generated/meshtastic/telemetry.pb.h Outdated Show resolved Hide resolved
src/detect/ScanI2CTwoWire.cpp Show resolved Hide resolved
@pr000t pr000t requested a review from caveman99 May 6, 2024 06:06
Copy link
Member

@caveman99 caveman99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a technicality: can you please allow maintainer edits on your branch? I need to fast-forward it to HEAD to merge it, and i can't do that without maintainer edit permission.

@pr000t pr000t requested a review from thebentern May 8, 2024 12:00
@thebentern thebentern merged commit 5371f13 into meshtastic:master May 8, 2024
62 of 64 checks passed
thebentern added a commit that referenced this pull request May 10, 2024
thebentern added a commit that referenced this pull request May 10, 2024
thebentern added a commit that referenced this pull request May 10, 2024
thebentern added a commit that referenced this pull request May 10, 2024
thebentern added a commit that referenced this pull request May 10, 2024
tavdog pushed a commit to tavdog/meshtastic-firmware that referenced this pull request May 10, 2024
* add Sensirion SHT4X sensors

* Update platformio.ini

Fix lib version

* Delete src/mesh/generated/meshtastic/telemetry.pb.h

* Revert "Delete src/mesh/generated/meshtastic/telemetry.pb.h"

This reverts commit 8e5e6a9.

* remove modification on generated file

* Update ScanI2CTwoWire.cpp

Fix copy/paste issue

---------

Co-authored-by: Thomas Göttgens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants