-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sensirion SHT4X sensors #3792
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caveman99
requested changes
May 5, 2024
caveman99
requested changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just a technicality: can you please allow maintainer edits on your branch? I need to fast-forward it to HEAD to merge it, and i can't do that without maintainer edit permission.
Fix lib version
This reverts commit 8e5e6a9.
caveman99
approved these changes
May 6, 2024
thebentern
reviewed
May 8, 2024
Fix copy/paste issue
thebentern
approved these changes
May 8, 2024
thebentern
added a commit
that referenced
this pull request
May 10, 2024
This reverts commit 5371f13.
thebentern
added a commit
that referenced
this pull request
May 10, 2024
thebentern
added a commit
that referenced
this pull request
May 10, 2024
This reverts commit 5371f13.
thebentern
added a commit
that referenced
this pull request
May 10, 2024
thebentern
added a commit
that referenced
this pull request
May 10, 2024
tavdog
pushed a commit
to tavdog/meshtastic-firmware
that referenced
this pull request
May 10, 2024
* add Sensirion SHT4X sensors * Update platformio.ini Fix lib version * Delete src/mesh/generated/meshtastic/telemetry.pb.h * Revert "Delete src/mesh/generated/meshtastic/telemetry.pb.h" This reverts commit 8e5e6a9. * remove modification on generated file * Update ScanI2CTwoWire.cpp Fix copy/paste issue --------- Co-authored-by: Thomas Göttgens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SHT45 sensor.
For the SHT40 and SHT41, the registerValue in ScanI2CTwoWire.cpp need to be added.