T-Echo screen and button performance #3840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Easier multi-clicks for features like "toggle backlight" (4x click)
Disables ghost pixel tracking: T-Echo ghost pixels are fairly faint.
|
Really nice, much easier with quad click for backlight now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small tweaks which I believe improve the T-Echo UX. Changes affect only the T-Echo.
Disable ghost-pixel tracking
"Ghost pixels" referring to the after-image left by setting black pixels to white with a fast refresh.
These artifacts are fairly faint for this model of display, and there doesn't seem to be much benefit in tracking / actively avoiding them with the T-Echo. Disabling this results in fewer full-refreshes; a smoother experience.
Increase the "click ms" value
This value determines how long a button waits to register a double-press, before accepting the current input as a single click. This PR increases the value from 250ms to 400ms. I don't believe this is perceptible when single-pressing, as the display refresh operation is fairly slow.
The benefit is that the double, triple, and quad presses are easier to execute.
To enable this change, the PR allows for variant-specific "click ms" values. If not specified, the current values are used as a default.