Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Hops away" on display #3934

Merged
merged 10 commits into from
May 24, 2024
Merged

Conversation

capslockapocalypse
Copy link
Contributor

Added in logic that displays "hops away" instead of signal strength on the display when the node is more than 0 hops away.
Any feedback to tidy up is appreciated.

Added in logic that displays "hops away" instead of signal strength when the node is more than 0 hops away.
@CLAassistant
Copy link

CLAassistant commented May 19, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@capslockapocalypse capslockapocalypse marked this pull request as draft May 19, 2024 06:41
@capslockapocalypse capslockapocalypse marked this pull request as ready for review May 19, 2024 06:45
@capslockapocalypse
Copy link
Contributor Author

Apologies If I'm not doing this right, first time using github and contributing. I'm assuming I need to get the Trunk Check Runner to pass? and that it's hanging on the extensions file.

@thebentern
Copy link
Contributor

Apologies If I'm not doing this right, first time using github and contributing. I'm assuming I need to get the Trunk Check Runner to pass? and that it's hanging on the extensions file.

Everything looks good on that front. You just need to revert your commit to the .vscode/extensions.json file. :-)

@capslockapocalypse
Copy link
Contributor Author

Thank you for your help and patience, if this doesn't work I'll just retry the whole pull request.

@thebentern thebentern merged commit 2233507 into meshtastic:master May 24, 2024
79 checks passed
@HarukiToreda
Copy link
Contributor

Added in logic that displays "hops away" instead of signal strength on the display when the node is more than 0 hops away. Any feedback to tidy up is appreciated.

do you have some screenshots to show it looks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants