Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak when there's no display #3972

Merged
merged 1 commit into from
May 26, 2024
Merged

Fix memory leak when there's no display #3972

merged 1 commit into from
May 26, 2024

Conversation

mskvortsov
Copy link
Contributor

The string does never get freed when useDisplay is false.

firmware/src/graphics/Screen.h

Lines 228 to 231 in 2233507

cmd.print_text = strdup(text);
if (!enqueueCmd(cmd)) {
free(cmd.print_text);
}

@thebentern thebentern merged commit aa33ad1 into meshtastic:master May 26, 2024
81 checks passed
@clwgh clwgh mentioned this pull request May 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebentern thebentern thebentern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mskvortsov @thebentern