-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added AHTx0 sensor #3977
added AHTx0 sensor #3977
Conversation
You can add the sensor definiton here: https://github.com/meshtastic/protobufs/blob/5f78a06c0fe5d0bd99c2fe206165212bdce89da0/meshtastic/telemetry.proto#L347 |
If BMP280+AHT20 detected, grab only humidity from AHT20... |
I have added sensor definition in my cloned repository |
Please revert changes to the gitignore and gitmodules files. |
Done |
.gitignore
Outdated
# !.vscode/settings.json | ||
# !.vscode/tasks.json | ||
# !.vscode/extensions.json | ||
# *.code-workspace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert
.gitmodules
Outdated
@@ -1,3 +1,3 @@ | |||
[submodule "protobufs"] | |||
path = protobufs | |||
url = https://github.com/meshtastic/protobufs.git | |||
url = https://github.com/fzellini/meshtastic-protobufs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert back
Done
Il giorno ven 31 mag 2024 alle ore 16:31 Alexander Smyslov <
***@***.***> ha scritto:
… ***@***.**** commented on this pull request.
------------------------------
In .gitmodules
<#3977 (comment)>:
> @@ -1,3 +1,3 @@
[submodule "protobufs"]
path = protobufs
- url = https://github.com/meshtastic/protobufs.git
+ url = https://github.com/fzellini/meshtastic-protobufs
Please revert back
—
Reply to this email directly, view it on GitHub
<#3977 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB5UW3X4T354Z6AZWQ736PTZFCCV3AVCNFSM6AAAAABISWV6G2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAOJRGAYDGNRSGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
.gitignore changes are still present. Please revert it |
Please check now.
Il giorno ven 31 mag 2024 alle ore 17:49 Ben Meadors <
***@***.***> ha scritto:
… .gitignore changes are still present. Please revert it
—
Reply to this email directly, view it on GitHub
<#3977 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB5UW3WA444VHU3YWGUEID3ZFCLYDAVCNFSM6AAAAABISWV6G2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBSGUZTOMBRHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
hi, thank you for adding aht20 support!
Could please explain the decision here? I found that aht20's temperature accuracy is \pm 0.3, while bmp280 is \pm 1. So technically aht20 is more accurate? |
Not my decision. If you read the all expanded thread , caveman99 says.. "I'd prefer the Bosch chip over the AHT". So i have implemented in that way. But if ATH20 is more accurate, i agree with you |
Sorry, I didn't go through the whole thread. Let me open a new issue and cc caveman99 to see if we can switch to aht20 |
Hi, I have added the AHT10 sensor to the project, so, with inexpensive modules containing bmp280&AHT20 you have pressure, temp & humidity.