Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash during reset NodeDB (dereferencing null pointer).
The order of statements in
resetNodes()
is wrong. First,numMeshNodes
is set to 1, but after that (inclearLocalPosition()
) the nodeId is searched in the meshDB, which cannot be found anymore, because meshDB is set to one element already.Note: normally this may not happen, as the own node is at position 0 (the only one element which is found). But when running MQTT with hundreds of nodes the own node seems not at position 0 anymore -> crash.
Another question is: who wrote code that reorders the own node away from position 0? Should not be necessary at all, right?