Triple-press not disabling GPS #4041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caveman99
requested changes
Jun 5, 2024
Possibly more intuitive when reading logs
thebentern
approved these changes
Jun 5, 2024
caveman99
approved these changes
Jun 7, 2024
slash-bit
pushed a commit
to slash-bit/meshtastic-echo-echo
that referenced
this pull request
Jul 4, 2024
* Replace (bool) isAwake with an enum, to track standby states * Tidy-up, extra logging * Rename enum values * Reorder GPSPowerState enum Possibly more intuitive when reading logs * Avoid lego comments https://github.com/meshtastic/firmware/pull/4041/files/de22c57298535f8b94154bffbef64a44af09648c#r1627334779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where triple-pressing the user button may not change the output at
PIN_GPS_ENReplaces a boolean, which didn't differentiate between "off" and "standby", with an enum.