Minimized build fixes #4049
Merged
Minimized build fixes #4049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt check status of is_mqtt_connected
…efined. Moved IFDEF HAS_NETWORK to beginning of MQTT:runOnce (to catch when EXCLUDE_WIFI is defined)
thebentern
approved these changes
Jun 6, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was working through configuration.h on the Minimized Builds options and was running into a couple of issues, so fixed up some minor changes to allow it to build correctly.
Made a minor changes to AdminModule.cpp to include modules/PositionModule.h when MESHTASTIC_EXCLUDE_GPS is defined.
Made a minor change to WiFiAPClient.cpp to not attempt to reconnect MQTT if MESHTASTIC_EXCLUDE_MQTT is defined.
Made a minor change to AdminModule.cpp to not attempt to check if MQTT is connected if MESHTASTIC_EXCUDE_MQTT is defined
In MQTT.cpp moved #ifdef HAS_NETWORKING further up the function to catch when EXCLUDE_MESHTASTIC_WIFI is defined.
In main-esp32.cpp created a ifndef and ifdef statement to have the right IF statement when EXCLUDE_MESHTASTIC_WIFI is defined.
No fixes for MESHTASTIC_EXCLUDE_MODULES as there are many to go through.
No issue to link, just cleaning up build issues for minimized builds.